another iteration of API experiments #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This relates to issue TestStack#9, also see discussion under pull request TestStack#12 and TestStack#11
|
@JakeGinnivan let me know what you think about the direction |
so ConventionData now has an interface, not so POCO anymore, but we get to have 2LOC conventions
They are pretty nasty to look at, since we're pretty much dealing with raw XML of the .csproj. We probably want to build some sort of abstraction over that (or use the existing one from Microsoft.MsBuild.something.dll
removed non used files/types moved types around project/namespaces to declutter the intellisense experience
|
Awesome stuff, am going to merge, then put another PR up with some more ideas I had while reading your PR. Also going to put the specific exceptions back in, and get rid of the settings. Will leave approval tests in, have an idea for that |
JakeGinnivan
pushed a commit
that referenced
this pull request
Jul 31, 2013
another iteration of API experiments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to issue #9, also see discussion under pull request #12 and #11